K 10 svn:author V 8 netchild K 8 svn:date V 27 2005-09-12T18:33:33.000000Z K 7 svn:log V 1142 - Fix the locking in dsp.c to prevent a LOR (AFAIK not on the LOR page). - Remove an assertion in sound.c, it's not needed (and causes a panic now). From the conversation via mail between glebius and Ariff: ---snip--- > Well, but which mutex protects now? Do we own anything else > in pcm_chnalloc()? I see some queue(4) macros in pcm_chnalloc(), > they should be protected, shouldn't they? Queue insertion/removal occur during 1) driver loading (which is pretty much single thread / sequential) or unloading (mutex protected, bail out if there is any channel with refcount > 0 or busy). 2) vchan_create()/destroy(), (which is *sigh* quite complicated), but somehow protected by 'master'/parent channel mutex. Other thread cannot add/remove vchan (or even continue traversing that queue) unless it can acquire parent channel mutex. ---snip--- Fix the locking in dsp.c to prevent a LOR (AFAIK not on the LOR page). Submitted by: Ariff Abdullah Tested with: INVARIANTS[1] and DIAGNOSTICS[2] Tested by: netchild [1,2], David Reid [1] END