K 10
svn:author
V 7
glebius
K 8
svn:date
V 27
2012-04-10T19:11:09.777309Z
K 7
svn:log
V 765
Get rid of copyin/copyout under locks in the pf table ioctls.
This is done by allocation enough memory before entering the
locked code.

Ioctls fixed:
DIOCRADDTABLES  +
DIOCRDELTABLES  +
DIOCRGETTABLES  +
DIOCRGETTSTATS  +
DIOCRCLRTSTATS  +
DIOCRSETTFLAGS
DIOCRADDADDRS   +
DIOCRDELADDRS   +
DIOCRSETADDRS   +
DIOCRGETADDRS   +
DIOCRCLRASTATS
DIOCRTSTADDRS   +
DIOCRINADEFINE  +

Lack of + means that the ioctl wasn't tested, due to absence
of it in the pfctl. However, code is quite similar, so I think
these couple is also okay.

While here, clean up some more code:
- Don't pretend that we can use M_WAITOK in ioctl path. We can't.
  We need to acquire lock quite prior to allocating memory, and
  to fix that quite a lot needs to be redesigned.
- Remove spl(9)

END