K 10
svn:author
V 6
rstone
K 8
svn:date
V 27
2013-03-08T21:07:01.827238Z
K 7
svn:log
V 822
MFC r244631
  Correct a series of errors in the hand-rolled locking for drace_debug.c:

  - Use spinlock_enter()/spinlock_exit() to prevent a thread holding a
    debug lock from being preempted to prevent other threads waiting
    on that lock from starvation.

  - Handle the possibility of CPU migration in between the fetch of curcpu
    and the call to spinlock_enter() by saving curcpu in a local variable.

  - Use memory barriers to prevent reordering of loads and stores of the
    data protected by the lock outside of the critical section

  - Eliminate false sharing of the locks by moving them into the structures
    that they protect and aligning them to a cacheline boundary.

  - Record the owning thread in the lock to make debugging future problems
    easier.

  Reviewed by:  rpaulo (initial version)

END