K 10
svn:author
V 5
markm
K 8
svn:date
V 27
2013-11-10T16:33:14.991693Z
K 7
svn:log
V 852
This counts as a pretty heavy code review, much overdue.

* Simplify the code where possible; remove unneeded variables, excess macro wrapping and useless code. Tidy comments etc.

* Combine common code into files; the harvest.c file was particularly confusing.

* The dummy fallback is an inherent part of the device; don't pretend it is a separate module.

* Attempt to make the modularisation complete. This is unfinished, in that unloading random.ko may cause panics.

* Reduce excess header inclusion where this was found.

* Don't unconditionally (re)seed the Yarrow device on boot; there is adequate entropy for it to start by itself with default settings. This was nasty; I managews to get an auto-seed in an unsafe state by fiddling. This is too bad of a foot-shooter to mess with.

I'm now much happier with this from a security perspective.

END