K 10
svn:author
V 6
emaste
K 8
svn:date
V 27
2021-01-15T14:27:34.166042Z
K 7
svn:log
V 916
libc: fix undefined behavior from signed overflow in strstr and memmem

unsigned char promotes to int, which can overflow when shifted left by
24 bits or more. this has been reported multiple times but then
forgotten. it's expected to be benign UB, but can trap when built with
explicit overflow catching (ubsan or similar). fix it now.

note that promotion to uint32_t is safe and portable even outside of
the assumptions usually made in musl, since either uint32_t has rank
at least unsigned int, so that no further default promotions happen,
or int is wide enough that the shift can't overflow. this is a
desirable property to have in case someone wants to reuse the code
elsewhere.

musl commit: 593caa456309714402ca4cb77c3770f4c24da9da

Obtained from:	musl

(cherry picked from commit 33482dae89c26158a22ccb3b7f2ca6e6652f29b4)

Git Hash:   56880a50139647318a123d67fe459ca840351729
Git Author: emaste@FreeBSD.org
END