K 10
svn:author
V 7
git2svn
K 8
svn:date
V 27
2021-02-20T19:50:30.706520Z
K 7
svn:log
V 647
pkg(7): address minor nits (mostly clang-analyze complaints)

- One (1) spurious whitespace.
- One (1) occurrence of "random(3) bad, arc4random(3)" good.
- Three (3) writes that will never be seen.

The latter two points are complaints from clang-analyze. Switching to
arc4random(3) is decidedly a good idea because we weren't doing any kind
of PRNG seeding anyways. The discarded assignments are arguably good
for future-proofing, but it's better to improve the S/N ratio from
clang-analyze.

(cherry picked from commit b2c4ca8d2872bc4410626f2b1ceafa49de5828ce)

Git Hash:   26682c1fa74c32fe3fdd250bb1481714197b0b51
Git Author: kevans@FreeBSD.org
END