K 10
svn:author
V 7
git2svn
K 8
svn:date
V 27
2022-02-04T14:24:33.347511Z
K 7
svn:log
V 980
pf: protect the rpool from races

The roundrobin pool stores its state in the rule, which could
potentially lead to invalid addresses being returned.

For example, thread A just executed PF_AINC(&rpool->counter) and
immediately afterwards thread B executes PF_ACPY(naddr, &rpool->counter)
(i.e. after the pf_match_addr() check of rpool->counter).

Lock the rpool with its own mutex to prevent these races. The
performance impact of this is expected to be low, as each rule has its
own lock, and the lock is also only relevant when state is being created
(so only for the initial packets of a connection, not for all traffic).

See also:	https://redmine.pfsense.org/issues/12660
Reviewed by:	glebius
MFC after:	3 weeks
Sponsored by:	Rubicon Communications, LLC ("Netgate")
Differential Revision:	https://reviews.freebsd.org/D33874

(cherry picked from commit 5f5e32f1b3945087a687c5962071d3f46e34e1ff)

Git Hash:   a9f1b6ccfa8279f30a705482cd780523eac9032e
Git Author: kp@FreeBSD.org
END