K 10
svn:author
V 6
jesper
K 8
svn:date
V 27
2001-02-24T18:36:01.000000Z
K 7
svn:log
V 1257
MFC:

src/sys/netinet/in_pcb.c     rev 1.78
src/sys/netinet/in_pcb.h     rev 1.36
src/sys/netinet/tcp_subr.c   rev 1.91
src/sys/netinet/udp_usrreq.c rev 1.86

Without this a attacker sending ICMP messages, where the attached
IP header (+ 8 bytes) has the address and port numbers == 0, would
have the ICMP message applied to all sessions.

The changes broken down:

  - remove 0 as a wildcard for addresses and port numbers in
    src/sys/netinet/in_pcb.c:in_pcbnotify()
  - add src/sys/netinet/in_pcb.c:in_pcbnotifyall() used to notify
    all sessions with the specific remote address.
  - change
    - src/sys/netinet/udp_usrreq.c:udp_ctlinput()
    - src/sys/netinet/tcp_subr.c:tcp_ctlinput()
    to use in_pcbnotifyall() to notify multiple sessions, instead of
    using in_pcbnotify() with 0 as src address and as port numbers.
  - remove check for src port == 0 in
    - src/sys/netinet/tcp_subr.c:tcp_ctlinput()
    - src/sys/netinet/udp_usrreq.c:udp_ctlinput()
    as they are no longer needed.
  - move handling of redirects and host dead from in_pcbnotify() to
    udp_ctlinput() and tcp_ctlinput(), so they will call
    in_pcbnotifyall() to notify all sessions with the specific
    remote address.

Approved by:    kris
Inspired by:    NetBSD

END