K 10
svn:author
V 8
tcberner
K 8
svn:date
V 27
2020-05-24T20:22:13.114330Z
K 7
svn:log
V 1061
devel/kf5-kio: add upstream bug fix: "Could not find the program ‘konsole’"

From upstrams [1] bug report

Fix service file specifying 'Run in terminal' giving an error code 100

Happens because KIO::DesktopExecParser::resultingArguments() prepends
the terminal application to the command line.  If this is a relative path,
as it is most likely to be (and will be in the default 'konsole' case),
the "realExecutable" check in KProcessRunner::KProcessRunner() is triggered
and the job aborts with an error.

Expand the specified terminal executable into a full path in resultingArguments(),
and return an error immediately if it cannot be found.  This full terminal path
is not relative for the KProcessRunner::KProcessRunner() check and does not fail.

Check that resultingArguments() is not empty (an error return) before accessing
the first word of the command, so that it does not assert if the list is empty.
Also only call resultingArguments() once.

[1] https://bugs.kde.org/show_bug.cgi?id=421374

PR:		246659
Reported by:	Serge Volkov <sv@ulstu.ru>

END